[PATCH] D49936: [ARM] Support the .isnt directive for MachO and COFF targets

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

I can't comment too much on the use of .inst in machO and Windows. I have a small suggestion that might make it possible to share more of the implementation, but it is only a personal preference.



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMTargetStreamer.cpp:52
 
+void ARMTargetStreamer::emitInst(uint32_t Inst, char Suffix) {
+  unsigned Size;
----------------
This looks almost identical to ARMELFStreamer::emitInst() with just the EmitARMMappingSymbol() and EmitThumbMappingSymbol().

Would it be possible to add a hook for adding the mapping symbol that the ELF backend can override and then make it use the implementation in ARMTargetStreamer?


Repository:
  rL LLVM

https://reviews.llvm.org/D49936