[PATCH] D49676: [DWARF] support for .debug_addr (consumer)
Victor Leschuk via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 30 03:25:51 PDT 2018
vleschuk marked an inline comment as done.
vleschuk added inline comments.
================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:1625
+ uint8_t Addr = 0;
+ for (const auto &CU : compile_units()) {
+ Addr = CU->getAddressByteSize();
----------------
jhenderson wrote:
> Nit: I think this needs to be the explicit type, rather than auto, based on the coding style guide.
Actually this will differ from the style used in this particular file. I think we should leave auto here.
https://reviews.llvm.org/D49676
More information about the llvm-commits
mailing list