[PATCH] D49271: Adding libc++ formattors for std::optional

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

Thanks for looking out for the bots.

I am afraid the compiler check will not be enough here. After that, you'll run into the issue of the system libc++ not being recent enough to contain std::optional. I suppose this could be handled by including some other header first (to make sure `__config` is evaluated) and then checking the `_LIBCPP_VERSION` macro.

I am sorry that this is so annoying. It's surprising that this is the first time we're running into this, but I guess this is the first data formatter for something that hasn't been implemented in libc++ since forever.


Repository:
  rL LLVM

https://reviews.llvm.org/D49271