[PATCH] D49026: [AMDGPU] New tbuffer intrinsics

[Tim Renouf via Phabricator via llvm-commits]

tpr added inline comments.


================
Comment at: test/CodeGen/AMDGPU/llvm.amdgcn.tbuffer.store.ll:73-80
+; GCN: tbuffer_store_format_xyzw v[0:3], v6, s[0:3], dfmt:14, nfmt:2, 0 idxen
 define amdgpu_ps void @buffer_store_wait(<4 x i32> inreg, <4 x float> %vdata, i32 %vindex.1, i32 %vindex.2, i32 %vindex.3) {
 main_body:
   %in1 = bitcast <4 x float> %vdata to <4 x i32>
   call void @llvm.amdgcn.tbuffer.store.v4i32(<4 x i32> %in1, <4 x i32> %0, i32 %vindex.1, i32 0, i32 0, i32 0, i32 15, i32 3, i1 0, i1 0)
   %data = call <4 x float> @llvm.amdgcn.buffer.load.format.v4f32(<4 x i32> %0, i32 %vindex.2, i32 0, i1 0, i1 0)
   %data.i = bitcast <4 x float> %data to <4 x i32>
----------------
arsenm wrote:
> Why the change in argument values?
16 is an illegal dfmt (it is only 4 bits), so the test was invalid.


Repository:
  rL LLVM

https://reviews.llvm.org/D49026