[PATCH] D49965: [MS Demangler] Demangle symbols in function local scopes

[David Majnemer via Phabricator via llvm-commits]

majnemer added a comment.

In https://reviews.llvm.org/D49965#1179735, @zturner wrote:

> I had thought of a tryDemangleNumber function but it didn’t really fit the
>  style of code . (Ie I don’t really do that anywhere else so it felt a
>  little out of place). I can still do that if you think it’s better, I don’t
>  have a strong preference


SGTM, LGTM w/ a nit.



================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:432
+  Candidate = Candidate.dropBack();
+
+  // An encoded number starts with B-P and all subsequent digits are in A-P.
----------------
What prohibits the string from being empty after this point?


https://reviews.llvm.org/D49965