[PATCH] D49950: [Polly][JSONExporter] Replace bundled Jsoncpp with LLVM's JSON.h. NFC.
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 28 17:45:41 PDT 2018
Meinersbur added a comment.
In https://reviews.llvm.org/D49950#1179316, @sammccall wrote:
> Usage of `JSON.h` looks pretty good, thanks for doing this migration!
Thanks for the review!
"JSONExporter" is meant for supporting development, esp. regression tests. Input verification is incomplete, before and after this patch, and could trigger UB. A GSoC students added some verification last year, but still not for all cases. This patch is meant as a conversion, so does not add additional verifications.
Repository:
rPLO Polly
https://reviews.llvm.org/D49950
More information about the llvm-commits
mailing list