[PATCH] D49954: [InstCombine] Fold Select with binary op

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D49954#1179406, @xbolva00 wrote:

> Can I precommit tests?


Yes, but please make sure we have at least 1 positive test for each potential opcode that is folded. If you want to leave the non-commutative and FP opcodes out of the initial patch, that's fine, but it should be marked with a TODO comment (and we'll eventually need tests for those). We'll also need tests for the 'ne' predicate.



================
Comment at: test/Transforms/InstCombine/select-binop-icmp.ll:4
+
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
Unnecessary - the transform is target-independent.


https://reviews.llvm.org/D49954