[PATCH] D49958: [MISC]Fix wrong usage of std::equal()
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 28 09:33:50 PDT 2018
lebedev.ri added reviewers: dberlin, davide, craig.topper, jmolloy.
lebedev.ri added subscribers: dberlin, jmolloy.
lebedev.ri added a comment.
But yes, i think the LHS of the diff looks at least strange..
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2919
// Min/max matching is only viable if all output VTs are the same.
- if (std::equal(ValueVTs.begin(), ValueVTs.end(), ValueVTs.begin())) {
EVT VT = ValueVTs[0];
----------------
This seems to originate from @jmolloy from rL237423.
================
Comment at: llvm/lib/Transforms/Scalar/NewGVN.cpp:3179-3180
if (!Okay)
- Okay =
- std::equal(OperandList.begin(), OperandList.end(), OperandList.begin());
if (Okay)
----------------
This seems to originate from @dberlin from rL299298 / rL291698.
https://reviews.llvm.org/D49958
More information about the llvm-commits
mailing list