[PATCH] D49944: [Dominators] Make applyUpdate's documentation less confusing [NFC]

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 27 17:54:31 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL338184: [Dominators] Make applyUpdate's documentation less confusing [NFC] (authored by kuhar, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D49944?vs=157786&id=157818#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D49944

Files:
  llvm/trunk/include/llvm/Support/GenericDomTree.h


Index: llvm/trunk/include/llvm/Support/GenericDomTree.h
===================================================================
--- llvm/trunk/include/llvm/Support/GenericDomTree.h
+++ llvm/trunk/include/llvm/Support/GenericDomTree.h
@@ -530,11 +530,10 @@
   /// CFG about its children and inverse children. This implies that deletions
   /// of CFG edges must not delete the CFG nodes before calling this function.
   ///
-  /// Batch updates should be generally faster when performing longer sequences
-  /// of updates than calling insertEdge/deleteEdge manually multiple times, as
-  /// it can reorder the updates and remove redundant ones internally.
-  /// The batch updater is also able to detect sequences of zero and exactly one
-  /// update -- it's optimized to do less work in these cases.
+  /// The applyUpdates function can reorder the updates and remove redundant
+  /// ones internally. The batch updater is also able to detect sequences of
+  /// zero and exactly one update -- it's optimized to do less work in these
+  /// cases.
   ///
   /// Note that for postdominators it automatically takes care of applying
   /// updates on reverse edges internally (so there's no need to swap the


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49944.157818.patch
Type: text/x-patch
Size: 1205 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180728/7b6480e0/attachment.bin>


More information about the llvm-commits mailing list