[PATCH] D49948: [test-suite] Add Image Processing Kernels Using Benchmark Library: Anisotropic diffusion

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 27 16:59:00 PDT 2018


Meinersbur added a comment.

Wow, that's 10x fast with Polly!



================
Comment at: MicroBenchmarks/ImageProcessing/AnisotropicDiffusion/anisotropicDiffusionKernel.c:10
+
+#define TIME_STEP 1.0 / 8
+#define DIFFUSION_CONST 0.5
----------------
[suggestion] Parenthesize to avoid precedence issues: `#define TIME_STEP (1.0 / 8)`


================
Comment at: MicroBenchmarks/ImageProcessing/AnisotropicDiffusion/main.cpp:41-42
+
+  int *outputImage;
+  outputImage = (int *)malloc(sizeof(int) * (HEIGHT) * (WIDTH));
+  if (outputImage == NULL) {
----------------
[nit] Can be on one line: ` int *outputImage = (int*) malloc(...`


Repository:
  rT test-suite

https://reviews.llvm.org/D49948





More information about the llvm-commits mailing list