[PATCH] D49870: [llvm-objcopy] Add support for --rename-section flags from gnu objcopy

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 27 15:56:06 PDT 2018


alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:233
+  if (!FlagValue.contains('='))
+    error("Bad format for --rename-section: expected '='");
+
----------------
is there a test for this error ? if not - would you mind adding one ?

+ question (just in case): do the error messages match binutils' ones ?


Repository:
  rL LLVM

https://reviews.llvm.org/D49870





More information about the llvm-commits mailing list