[PATCH] D49942: [ASAN] Port asan to FreeBSD/mips64.

[John Baldwin via Phabricator via llvm-commits]

bsdjhb added a comment.

The LLVM changes to use the correct shadow offset on FreeBSD/mips64 are in https://reviews.llvm.org/D49939.



================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:1249
 }
-#elif defined(__mips__)
+#elif defined(__mips__) && SANITIZER_LINUX
 uptr internal_clone(int (*fn)(void *), void *child_stack, int flags, void *arg,
----------------
Rather than adding '&& SANITIZER_LINUX' to the #ifdef for each architecture as they are ported to other systems, we might consider wrapping all of the 'internal_clone' implementations in a single '#if SANITIZER_LINUX'.


================
Comment at: lib/sanitizer_common/sanitizer_syscall_generic.inc:46
 # endif
-#elif defined(__x86_64__) && (SANITIZER_FREEBSD || SANITIZER_MAC)
+#elif SANITIZER_FREEBSD || (defined(__x86_64__) && SANITIZER_MAC)
 # define internal_syscall __syscall
----------------
__syscall is valid for all FreeBSD platforms.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49942