[PATCH] D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges
Matt Morehouse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 27 14:15:57 PDT 2018
morehouse added inline comments.
================
Comment at: lib/fuzzer/FuzzerLoop.cpp:496
- if (Options.HandleUnstable || Options.PrintUnstableStats) {
+ if ((int)Options.HandleUnstable || Options.PrintUnstableStats) {
TPC.CollectFeatures([&](size_t Feature) {
----------------
Dor1s wrote:
> morehouse wrote:
> > These casts are quite awkward. Maybe we should just keep `Options.HandleUnstable` as an int.
> I sort of insisted on not using an int in there, but final decision would yours :)
Similar libFuzzer options all use int, so at least for consistency I think we should use an int.
I would prefer to get @kcc's opinion in a separate refactoring patch if you would like to switch from ints to enums.
https://reviews.llvm.org/D49578
More information about the llvm-commits
mailing list