[PATCH] D49040: [SLC] Simplify pow(x, 0.333...) to cbrt(x)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

If I'm seeing it correctly, there are several independent changes going on here. Can you split this up to make the review easier?

1. Add all new tests with baseline CHECKs as an NFC preliminary step.
2. It's not clear to me what the FMF diffs in pow-sqrt.ll are showing. If we are adjusting FMF constraints on existing folds, that should be an independent patch?
3. The cosmetic diffs in variable names (Base, Expo, Shrunk, etc) look fine, so those can be another preliminary NFC commit before the part that needs further review.
4. The cbrt transform can be the last patch/commit in this series; once we have the cleanup done, that should be a very small diff.


https://reviews.llvm.org/D49040