[PATCH] D49853: [gcov] Display the hit counter for the line of a function definition

[Marco Castelluccio via Phabricator via llvm-commits]

marco-c accepted this revision.
marco-c added a comment.
This revision is now accepted and ready to land.

I hope this won't have any side effects we are not expecting. The updated tests in compiler-rt all look good, so I'm reasonably confident.



================
Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:588
+      // to have a counter for the function definition
+      Func.getBlock(&F.getEntryBlock()).getFile(SP->getFilename()).addLine(SP->getLine());
+
----------------
Nit: you might try to use EntryBlock, if it still usable after the split. Not so important though.

The formatting seems to be off.


Repository:
  rL LLVM

https://reviews.llvm.org/D49853