[PATCH] D49791: [AArch64] - Generate pointer authentication instructions

[Luke Cheeseman via Phabricator via llvm-commits]

LukeCheeseman marked 3 inline comments as done.
LukeCheeseman added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:296
+  if(Scope.equals("all"))
+    return true;
+
----------------
ab wrote:
> Is this actually necessary?  "all" is still only functions that actually save LR, no?  Why sign it if it's not saved?
Yes, it is necessary.  "all" is all functions, even those that don't save the LR.  Assume you are in a context where you have managed to gain control over the flow of execution, if you don't sign the LR in any function that doesn't save the LR then these functions becomes the ideal place to find gadgets.


https://reviews.llvm.org/D49791