[PATCH] D49676: [DWARF] support for .debug_addr (consumer)

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugAddr.cpp:44
+    if (HeaderData.Length == 0xffffffffu)
+      return createStringError(errc::invalid_argument,
+          "DWARF64 is not supported in .debug_addr at offset 0x%" PRIx32 "\n",
----------------
vleschuk wrote:
> jhenderson wrote:
> > There is errc::not_supported, which I'd recommend for this.
> There is only errc::function_not_supported. I used this one.
> There is only errc::function_not_supported. I used this one.
Nope, `errc::not_supported` does definitely exist. Go to https://en.cppreference.com/w/cpp/error/errc and search for ENOTSUP for reference.

If it isn't there, then your standard library is not C++11 compliant...


https://reviews.llvm.org/D49676