[PATCH] D49883: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dilate Kernel

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: MicroBenchmarks/ImageProcessing/Dilate/dilateKernel.cpp:14-16
+// inpImage[HEIGHT * WIDTH]
+// outImage[height * width] 
+void dilateKernel(int *inpImage, int *outImage, int height, int width, int *temporary) {
----------------
Can you change the file type to C and use C99 VLA parameters here?


================
Comment at: MicroBenchmarks/ImageProcessing/Dilate/main.cpp:86
+  if (state.range(0) == 20) {
+    saveImage(outputImage, (const char *)"testFailed.txt", height, width);
+  }
----------------
proton wrote:
> Using the output image so that the "dilateKernel" calls above are not optimized out. This is is always false thought because we never pass state.range(0) as 20.
Could you add this as a comment into the source file?


Repository:
  rT test-suite

https://reviews.llvm.org/D49883