[PATCH] D49281: [Unroll/UnrollAndJam/Vectorizer/Distribute] Add followup loop attributes.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur marked 7 inline comments as done.
Meinersbur added inline comments.


================
Comment at: docs/TransformMetadata.rst:343
+
+Currently, the ``LoopInterchange`` pass does not use any metadata.
+
----------------
dmgreen wrote:
> Should we fix this? Will it work as expected with nonforced, if it was enabled?
Yes, but in a separate patch that adds interchange-specific metadata. LoopInterchange currently is not enabled by default and does not modify metadata so its interaction with other transformation is less significant.


================
Comment at: include/llvm/LinkAllPasses.h:221
       (void) llvm::createScalarizeMaskedMemIntrinPass();
+      (void)llvm::createWarnMissedTransformationsPass();
 
----------------
dmgreen wrote:
> Nit: Space I guess? I think this file could do with a clang-formatting
I used `git clang-format origin/master` which only applies to changed lines like this one.


================
Comment at: include/llvm/Transforms/Scalar/WarnMissedTransforms.h:35
+Pass *createWarnMissedTransformationsPass();
+void initializeWarnMissedTransformationsLegacyPass(PassRegistry &);
+} // end namespace llvm
----------------
dmgreen wrote:
> Are these two needed here, if they are declared in other places?
Depends on which headers are included when using this pass.

`WarnMissingTransforms.cpp` itself does not include `include/llvm/InitializePasses.h` or `include/llvm/Transforms/Scalar.h`. Having the forward declarations here matches the translation unit header idiom an the compiler checks that the definition matches the declaration here.


Repository:
  rL LLVM

https://reviews.llvm.org/D49281