[PATCH] D49689: [analyzer] Extend NoStoreFuncVisitor to insert a note on IVars

[George Karpenkov via Phabricator via llvm-commits]

george.karpenkov reopened this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.

Reopening as had to revert due to uncommitted dependency.



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:330
+          llvm::raw_svector_ostream os(sbuf);
+          os << DiagnosticsMsg << "self." << IVD->getName() << "'";
+          return std::make_shared<PathDiagnosticEventPiece>(L, os.str());
----------------
george.karpenkov wrote:
> NoQ wrote:
> > Shouldn't it say `self->`? Dot is kinda property syntax (?)
> that's how you refer to ivars in Objective-C.
ooops I was wrong.


Repository:
  rL LLVM

https://reviews.llvm.org/D49689