[PATCH] D49777: [LTO] Don't internalize declarations

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

LGTM with one minor comment nit below. See if pcc has any more comments though.



================
Comment at: llvm/lib/LTO/LTO.cpp:874
           RegularLTO.CombinedModule->getNamedValue(R.second.IRName);
-      // Ignore symbols defined in other partitions.
-      if (!GV || GV->hasLocalLinkage())
+      // Ignore and symbols defined in other partitions.
+      // Also skip declarations, which are not allowed to have internal linkage.
----------------
s/and/any/?


https://reviews.llvm.org/D49777