[PATCH] D48518: ADT: Shrink SmallVector by 8B on 64-bit platforms

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 18:02:24 PDT 2018


dexonsmith added a subscriber: rnk.
dexonsmith added a comment.

Hi Peter,

Thanks for the heads up.  I tend to agree with your intuition/conclusion (i.e., it seems like a bug in 3.8.1 and not worth reverting for).  But, FYI, I'll be OOO for a couple of weeks.  If for some reason your conclusion changes, please don't wait for my response before reverting.  I already know it won't revert cleanly because I committed r337820 (https://reviews.llvm.org/D49163 https://reviews.llvm.org/D49163) on top, but it should be pretty easy to resolve the conflict (you should just have to fine-tune the static_asserts).

Good luck,
Duncan


https://reviews.llvm.org/D48518





More information about the llvm-commits mailing list