[PATCH] D49870: [llvm-objcopy] Add support for --rename-section flags from gnu objcopy

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:521
+      if (Iter != Config.SectionsToRename.end()) {
+        auto &SectionConfig = Iter->second;
+        Sec.Name = SectionConfig.NewName;
----------------
alexshap wrote:
> here and in the other places:
> 1. when the type is not obvious we usually don't use auto (for better readability),
> 2. the names of the variable is kinda inconsistent with the type - the type is SectionRename - i'd name the variable smth like SR 
>  
typo: the name of the variable 


Repository:
  rL LLVM

https://reviews.llvm.org/D49870