[PATCH] D49700: [LLD] [COFF] Treat .xdata/.pdata$<sym> as implicitly associative to <sym> for MinGW

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 15:48:03 PDT 2018


rnk added a comment.

In https://reviews.llvm.org/D49700#1177436, @mstorsjo wrote:

> That said, I'm fine with moving forward with this patch; it makes the gcc compat issue list one item shorter at least. Are there any other issues with it, or other suggestions? Rui maybe wanted more comments?


We should try to make it faster. We don't want to hash every symbol we ever add, only the prevailing comdat ones. This will probably save a large number of hash table insertions, because oftentimes most comdat function definitions will be redundant and get discarded.


https://reviews.llvm.org/D49700





More information about the llvm-commits mailing list