[PATCH] D49240: [libc++] Introduce _LIBCPP_HIDE_FROM_ABI to replace _LIBCPP_INLINE_VISIBILITY

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 14:52:57 PDT 2018


ldionne added a comment.

In https://reviews.llvm.org/D49240#1177382, @EricWF wrote:

> LGTM. Assuming this doesn't break the ABI list checks.
>
> I talked to @ldionne about if we wanted to land this right before 7.0, but I think we can. If we have to disable the internal linkage change, we can at least keep the new naming scheme and start transitioning to it.


I'd like to get input from @mclow.lists and @dexonsmith about whether we should move forward with this before we branch 7.0, or wait after the release. This is a wide reaching change so I want to share responsibility ;-)


Repository:
  rL LLVM

https://reviews.llvm.org/D49240





More information about the llvm-commits mailing list