[PATCH] D49875: [MS Demangler]

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.
zturner added reviewers: rnk, majnemer, ruiu, thakis.
Herald added subscribers: erik.pilkington, hiraditya.

Properly demangle function parameter back-references.

Previously we treated lists of function parameters and template parameters the same.  There are some important differences with regards to back-references, and some less important differences regarding which characters can appear before or after the name.

The important differences are that with a given type T, all instances of a function parameter list share the same global back-ref table.  Specifically, if X and Y are function pointers, then there are 3 entities in the declaration `X func(Y)` which all affect and are affected by the master parameter back-ref table.  1) The parameter list of X's function type, 2) the parameter list of `func` itself, and 3) The parameter list of `Y`'s function type.

The previous code would create a back-reference table that was local to a single parameter list, so it would not be shared across parameter lists.

This was discovered when porting `ms-back-references.test` from clang's mangling tests.  All of these tests should now pass with the new changes.

In doing so, I split the function for parsing template and function parameters into two separate functions.  This makes the template parameter list parsing code in particular very small and easy to understand now.


https://reviews.llvm.org/D49875

Files:
  llvm/lib/Demangle/MicrosoftDemangle.cpp
  llvm/test/Demangle/ms-back-references.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49875.157579.patch
Type: text/x-patch
Size: 6377 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180726/eb0b2b43/attachment.bin>