[PATCH] D49503: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dither Algorithms

[Brian Homerding via Phabricator via llvm-commits]

homerdin added inline comments.


================
Comment at: MicroBenchmarks/ImageProcessing/Dither/floydDitherKernel.cpp:9
+#include "dither.h"
+  
+// inpImage[HEIGHT * WIDTH]
----------------
WhiteSpace


================
Comment at: MicroBenchmarks/ImageProcessing/Dither/floydDitherKernel.cpp:10-11
+  
+// inpImage[HEIGHT * WIDTH]
+// outImage[height * width] 
+void floydDitherKernel(int *inpImage, int *outImage, int height, int width) {
----------------
Commented Code


================
Comment at: MicroBenchmarks/ImageProcessing/Dither/orderedDitherKernel.cpp:17
+// inpImage[HEIGHT * WIDTH]
+// outImage[height * width] 
+void orderedDitherKernel(int *inpImage, int *outImage, int height, int width) {
----------------
Commented Code


================
Comment at: MicroBenchmarks/ImageProcessing/Dither/orderedDitherKernel.cpp:52
+
+  if (M == 2) {
+    int dither[2][2] = {{0, 2}, {3, 1}};
----------------
You could remove the M==2, M==3 and M==8 conditions since M is defined as 4?  That or you could pass another argument to set M and have a test for each size image with each value of M.


Repository:
  rT test-suite

https://reviews.llvm.org/D49503