[PATCH] D49770: [ARM64] [Windows] Follow MS X86_64 C++ ABI when passing structs
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 26 10:30:58 PDT 2018
rnk accepted this revision.
rnk added a comment.
Please avoid the extra enum case, and commit.
================
Comment at: include/clang/Basic/TargetInfo.h:1223
enum CallingConvKind {
CCK_Default,
----------------
This is poorly named. I'll try to send a patch to rename it after this lands.
================
Comment at: include/clang/Basic/TargetInfo.h:1226-1227
CCK_ClangABI4OrPS4,
- CCK_MicrosoftX86_64
+ CCK_MicrosoftX86_64,
+ CCK_MicrosoftARM64
};
----------------
IMO it'd be better to collapse these into something like `CCK_MicrosoftWin64`, since we don't treat them differently.
Repository:
rC Clang
https://reviews.llvm.org/D49770
More information about the llvm-commits
mailing list