[PATCH] D48959: [compiler-rt][ubsan] Implicit Cast Sanitizer - integer truncation - compiler-rt part

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 09:33:15 PDT 2018


lebedev.ri updated this revision to Diff 157508.
lebedev.ri marked an inline comment as done.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.

Address @filcab's review nit - merge `integer-truncation.{c,cpp}` tests into one.
They are basically identical, so it seems to be the best course of action.

In https://reviews.llvm.org/D48959#1176762, @filcab wrote:

> I have a nit I'd like to see addressed, otherwise LGTM.


Thank you for the review!


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48959

Files:
  lib/ubsan/ubsan_checks.inc
  lib/ubsan/ubsan_diag.h
  lib/ubsan/ubsan_handlers.cc
  lib/ubsan/ubsan_handlers.h
  lib/ubsan/ubsan_interface.inc
  lib/ubsan_minimal/ubsan_minimal_handlers.cc
  test/fuzzer/ImplicitIntegerTruncationTest.cpp
  test/fuzzer/fuzzer-implicit-integer-truncation.test
  test/ubsan/TestCases/ImplicitCast/integer-truncation-blacklist.c
  test/ubsan/TestCases/ImplicitCast/integer-truncation-summary.cpp
  test/ubsan/TestCases/ImplicitCast/integer-truncation.c
  test/ubsan_minimal/TestCases/implicit-integer-truncation.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48959.157508.patch
Type: text/x-patch
Size: 13981 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180726/8f5aea21/attachment.bin>


More information about the llvm-commits mailing list