[PATCH] D49860: [dsymutil] Simplify temporary file handling.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: jmorse, friss, probinson.
Herald added a subscriber: hiraditya.

Dsymutil's update functionality was broken on Windows because we tried to rename a file while we're holding open handles to that file. TempFile provides a solution for this through its `keep(Twine)` method. This patch changes dsymutil to make use of that functionality.


Repository:
  rL LLVM

https://reviews.llvm.org/D49860

Files:
  llvm/lib/Support/Path.cpp
  llvm/test/tools/dsymutil/X86/accelerator.test
  llvm/test/tools/dsymutil/X86/update-one-CU.test
  llvm/test/tools/dsymutil/X86/update.test
  llvm/tools/dsymutil/MachOUtils.cpp
  llvm/tools/dsymutil/MachOUtils.h
  llvm/tools/dsymutil/dsymutil.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49860.157495.patch
Type: text/x-patch
Size: 8690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180726/f5ff6c96/attachment.bin>