[PATCH] D49858: [RFC] re-enable GVNHoist by default
Alexandros Lamprineas via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 26 08:30:29 PDT 2018
labrinea created this revision.
labrinea added a reviewer: llvm-commits.
Herald added subscribers: dexonsmith, steven_wu, eraman, Prazek, mehdi_amini.
My initial motivation for this came from https://reviews.llvm.org/D48122, where it was pointed out that my change didn't fit well in SimplifyCFG and therefore using GVNHoist was a better way to go. GVNHoist has been disabled for a while as there was a list of bugs related to it.
I have fixed the following bugs:
- https://bugs.llvm.org/show_bug.cgi?id=37808 -> https://reviews.llvm.org/D48372 (https://reviews.llvm.org/rL337149)
- https://bugs.llvm.org/show_bug.cgi?id=36787 -> https://reviews.llvm.org/D49555 (https://reviews.llvm.org/rL337674)
- https://bugs.llvm.org/show_bug.cgi?id=37445 -> https://reviews.llvm.org/D49425 (https://reviews.llvm.org/rL337680)
The next two bugs no longer occur, and it's unclear which commit fixed them:
- https://bugs.llvm.org/show_bug.cgi?id=36635
- https://bugs.llvm.org/show_bug.cgi?id=37791
I investigated this one and proved to be unrelated to GVNHoist, but a genuine bug in NewGvn:
- https://bugs.llvm.org/show_bug.cgi?id=37660
To convince myself GVNHoist is in a good state I made a successful bootstrap build of LLVM followed by check-all.
https://reviews.llvm.org/D49858
Files:
lib/Passes/PassBuilder.cpp
lib/Transforms/IPO/PassManagerBuilder.cpp
test/Other/new-pm-defaults.ll
test/Other/new-pm-thinlto-defaults.ll
test/Other/opt-O2-pipeline.ll
test/Other/opt-O3-pipeline.ll
test/Other/opt-Os-pipeline.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49858.157487.patch
Type: text/x-patch
Size: 7879 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180726/664bd4f9/attachment.bin>
More information about the llvm-commits
mailing list