[PATCH] D47540: [lld] Enable Visual Studio compatible output

[Chris Jackson via Phabricator via llvm-commits]

chrisjackson added a comment.

@Ik

In https://reviews.llvm.org/D47540#1157167, @ikudrin wrote:

> Can we try the approach where the final style of diagnostic messages is determined in the reporting module and all other code just don't care about it?
>  Right now, we have a bunch of functions here and there which prepare some parts of the message in a specific style. Maybe it will be more semantically clear if there is a distinct place where the resulting message is prepared while all other parts of the linker provide only basic parts of the message (like message text, source location(s), code location(s), etc.) in a structured form. In this case, we can adjust only that distinct place to add any required message styles.


While more structured, I think this approach could be even more invasive than that suggested. Do you have an example implementation?

@ruiu 
Clang has specific visual studio diagnostics format support. Do you think their approach is too involved?


https://reviews.llvm.org/D47540