[llvm] r338030 - [test] Disable dsymutil update test on windows

[Jonas Devlieghere via llvm-commits]

Author: jdevlieghere
Date: Thu Jul 26 07:16:19 2018
New Revision: 338030

URL: http://llvm.org/viewvc/llvm-project?rev=338030&view=rev
Log:
[test] Disable dsymutil update test on windows

Apparently, the issue with dsymutil update functionality on Windows was
that Windows doesn't like dsymutil renaming files that have open handles
to them. This disables the new accelerator test and updates the comment
in the other two test.

We should be able to enable the tests again once we updated the
implementation to use TempFile::keep() to keep the temporary files in
MachOUtils.

A big thank you to Jeremy Morse from Sony for figuring this out and
bringing it to my attention.

Modified:
    llvm/trunk/test/tools/dsymutil/X86/accelerator.test
    llvm/trunk/test/tools/dsymutil/X86/update-one-CU.test
    llvm/trunk/test/tools/dsymutil/X86/update.test

Modified: llvm/trunk/test/tools/dsymutil/X86/accelerator.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/dsymutil/X86/accelerator.test?rev=338030&r1=338029&r2=338030&view=diff
==============================================================================
--- llvm/trunk/test/tools/dsymutil/X86/accelerator.test (original)
+++ llvm/trunk/test/tools/dsymutil/X86/accelerator.test Thu Jul 26 07:16:19 2018
@@ -1,3 +1,7 @@
+UNSUPPORTED: system-windows
+Windows does not like renaming files that have open handles to them. We
+need to use TempFile::keep to move them in a portable way.
+
 RUN: dsymutil -accelerator=Dwarf -oso-prepend-path=%p/.. %p/../Inputs/basic.macho.x86_64 -o %t.dwarf.dSYM
 RUN: dsymutil -accelerator=Apple -oso-prepend-path=%p/.. %p/../Inputs/basic.macho.x86_64 -o %t.apple.dSYM
 

Modified: llvm/trunk/test/tools/dsymutil/X86/update-one-CU.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/dsymutil/X86/update-one-CU.test?rev=338030&r1=338029&r2=338030&view=diff
==============================================================================
--- llvm/trunk/test/tools/dsymutil/X86/update-one-CU.test (original)
+++ llvm/trunk/test/tools/dsymutil/X86/update-one-CU.test Thu Jul 26 07:16:19 2018
@@ -1,5 +1,6 @@
 UNSUPPORTED: system-windows
-Remove UNSUPPORTED once we figure out why this fails on Windows.
+Windows does not like renaming files that have open handles to them. We
+need to use TempFile::keep to move them in a portable way.
 
 RUN: dsymutil -oso-prepend-path=%p/.. %p/../Inputs/objc.macho.x86_64 -o %t.dSYM
 RUN: dsymutil -update %t.dSYM

Modified: llvm/trunk/test/tools/dsymutil/X86/update.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/dsymutil/X86/update.test?rev=338030&r1=338029&r2=338030&view=diff
==============================================================================
--- llvm/trunk/test/tools/dsymutil/X86/update.test (original)
+++ llvm/trunk/test/tools/dsymutil/X86/update.test Thu Jul 26 07:16:19 2018
@@ -1,5 +1,6 @@
 UNSUPPORTED: system-windows
-Remove UNSUPPORTED once we figure out why this fails on Windows.
+Windows does not like renaming files that have open handles to them. We
+need to use TempFile::keep to move them in a portable way.
 
 RUN: rm -rf %t.dir
 RUN: mkdir -p %t.dir