[PATCH] D49676: [DWARF] support for .debug_addr (consumer)

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugAddr.cpp:125
+    for (const auto &Addr : Addrs) {
+      OS << format("\n0x%8.8" PRIx32, Addr); // TODO: 64bit addrs
+      if (DumpOpts.Verbose)
----------------
jhenderson wrote:
> Are you going to do 64-bit addresses immediately after this?
Other parts of the library (e.g. DWARFFormValue) unconditionally print a 64-bit address, regardless of the target address size.  This probably should be considered a bug in DWARFFormValue but if you print a 64-bit value here, at least it would be consistent with the rest of the library.


https://reviews.llvm.org/D49676