[PATCH] D49837: [SelectionDAG][X86] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect.
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 26 06:30:00 PDT 2018
lebedev.ri added a comment.
The IR pattern produced by https://reviews.llvm.org/D48754 is already matched into `ISD::ABS`? Or is there a third differential?
================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1388-1390
+ case ISD::ABS:
+ ExpandIntRes_ABS(N, Lo, Hi);
+ break;
----------------
Inconsistent with the rest.
Unless the final line is longer than 80-chars, make it one line?
Repository:
rL LLVM
https://reviews.llvm.org/D49837
More information about the llvm-commits
mailing list