[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added a comment.

+ we need tests ))



================
Comment at: include/llvm/Object/Compressor.h:45
+private:
+  Compressor() {}
+  Compressor(StringRef Data) : SectionData(Data) {}
----------------
is the default ctor used anywhere ? - otherwise, we can  remove it 


================
Comment at: include/llvm/Object/Compressor.h:46
+  Compressor() {}
+  Compressor(StringRef Data) : SectionData(Data) {}
+  StringRef SectionData;
----------------
explicit


================
Comment at: tools/llvm-objcopy/Object.h:397
   void finalize() override;
+  virtual bool isCompressable() const override {
+    StringRef GnuZDebugName =
----------------
here and below - i think the implementations should be moved to Object.cpp


Repository:
  rL LLVM

https://reviews.llvm.org/D49678