[PATCH] D49536: [Analyzer] Quick Fix for exponential execution time when simpilifying complex additive expressions

[Artem Dergachev via Phabricator via llvm-commits]

NoQ added a comment.

In https://reviews.llvm.org/D49536#1176128, @mikhail.ramalho wrote:

> I getting the following error when analyzing `test/Analysis/plist-macros.cpp`, usign z3 as constraint manager (`-analyzer-constraints=z3 -DANALYZER_CM_Z3`):
>
>   /home/mgadelha/llvm/tools/clang/test/Analysis/plist-macros.cpp:640:16: error: CHECK-NEXT: expected string not found in input
>   // CHECK-NEXT: <key>line</key><integer>36</integer>
>                  ^
>   /home/mgadelha/llvm/build/tools/clang/test/Analysis/Output/plist-macros.cpp.tmp.plist:562:2: note: scanning from here
>    <key>line</key><integer>37</integer>
>    ^
>
>
> I bisected back to this commit. I reverted it locally and the error goes away.
>
> Any idea why it doesn't work with z3?


Uhm, dunno, plist/FileCheck tests are annoying. What i usually do to make sense out of them is update the tested output with the actual output and look at git diff. From that it's usually obvious what exactly happened (warnings added, warnings removed, warnings moved to a different location, intermediate diagnostics added, intermediate diagnostics removed, intermediate diagnostics moved to a different location). Could you do that and see if it makes sense or attach the diff here so that we could have a look?


Repository:
  rL LLVM

https://reviews.llvm.org/D49536