[PATCH] D49676: [DWARF] support for .debug_addr (consumer)

[Victor Leschuk via Phabricator via llvm-commits]

vleschuk marked 2 inline comments as done.
vleschuk added inline comments.


================
Comment at: include/llvm/Support/Error.h:1126
+template <typename... Ts>
+Error createStringError(char const *Fmt, const Ts &... Vals) {
+  std::string Buffer;
----------------
jhenderson wrote:
> This should probably be unit tested.
Created separate review with simple unit test: https://reviews.llvm.org/D49824 .


================
Comment at: include/llvm/Support/Error.h:1132
+}
+
 /// Helper for check-and-exit error handling.
----------------
probinson wrote:
> Because the intent is for this to be useful more widely, it should be committed separately.  That way if you have to revert this patch, the utility template function remains in place for other users.
Created separate review with simple unit test: https://reviews.llvm.org/D49824 .


https://reviews.llvm.org/D49676