[PATCH] D49820: [ELF] Use search paths for --version-script=

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 15:02:10 PDT 2018


You could use %basename_t. I did it in r337972 for you.

On Wed, Jul 25, 2018 at 3:00 PM Fangrui Song via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaskRay added inline comments.
>
>
> ================
> Comment at: test/ELF/version-script-in-search-path.s:9
> +# RUN: ld.lld -L%T/searchpath --version-script=t.script %t.o -o /dev/null
> +# RUN: not ld.lld --version-script=t.script %t.o 2>&1 | FileCheck
> -check-prefix ERROR %s
> +# ERROR: error: cannot find version script
> ----------------
> ruiu wrote:
> > For safety, you should use `%T/searchpath/%t.script` instead of
> `%T/searchpath/t.script` because this line can succeed if there's other
> test that happens to create t.script in the current directory.
> Sorry I didn't notice this comment when committing.
>
> `%t.script` is an absolute path so it does not work here
> `--version-script=%t.script`
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D49820
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180725/8b565e75/attachment.html>


More information about the llvm-commits mailing list