[PATCH] D49821: [MC] Add support for the .rva assembler directive for COFF targets

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: lib/MC/MCParser/COFFAsmParser.cpp:515
+                   "invalid '.rva' directive offset, can't be less "
+                   "than std::numeric_limits<int32_t>::min() or greater than "
+                   "std::numeric_limits<int32_t>::max()");
----------------
Quoting C++ expressions in an error message is not very user friend, I'd stick in -2147483648


================
Comment at: lib/MC/MCParser/COFFAsmParser.cpp:516
+                   "than std::numeric_limits<int32_t>::min() or greater than "
+                   "std::numeric_limits<int32_t>::max()");
+
----------------
2147483647


Repository:
  rL LLVM

https://reviews.llvm.org/D49821