[PATCH] D49819: [bcanalyzer] Update MODULE_CODE values

Adam Newton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 13:38:15 PDT 2018


aenewton created this revision.
aenewton added reviewers: pcc, JDevlieghere.
Herald added a reviewer: george.karpenkov.
Herald added subscribers: llvm-commits, a.sidorin.

I noticed that the bcanalyzer was missing some MODULE_CODE values. It doesn't look like these codes are currently tested. Would it be advisable to create a test solely to check the proper output of these codes?


Repository:
  rL LLVM

https://reviews.llvm.org/D49819

Files:
  tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp


Index: tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
===================================================================
--- tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
+++ tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
@@ -175,12 +175,15 @@
       STRINGIFY_CODE(MODULE_CODE, DEPLIB) // FIXME: Remove in 4.0
       STRINGIFY_CODE(MODULE_CODE, GLOBALVAR)
       STRINGIFY_CODE(MODULE_CODE, FUNCTION)
-      STRINGIFY_CODE(MODULE_CODE, ALIAS)
+      STRINGIFY_CODE(MODULE_CODE, ALIAS_OLD)
       STRINGIFY_CODE(MODULE_CODE, GCNAME)
+      STRINGIFY_CODE(MODULE_CODE, COMDAT)
       STRINGIFY_CODE(MODULE_CODE, VSTOFFSET)
+      STRINGIFY_CODE(MODULE_CODE, ALIAS)
       STRINGIFY_CODE(MODULE_CODE, METADATA_VALUES_UNUSED)
       STRINGIFY_CODE(MODULE_CODE, SOURCE_FILENAME)
       STRINGIFY_CODE(MODULE_CODE, HASH)
+      STRINGIFY_CODE(MODULE_CODE, IFUNC)
     }
   case bitc::IDENTIFICATION_BLOCK_ID:
     switch (CodeID) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49819.157348.patch
Type: text/x-patch
Size: 930 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180725/353d3593/attachment.bin>


More information about the llvm-commits mailing list