[PATCH] D40369: Support sext instruction in SCEV delinearization algorithm (new revision)

[David Greene via Phabricator via llvm-commits]

greened added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:988
+
+    // This is from Manuel Selva's patch (https://reviews.llvm.org/D35478).
+    //  We have to put this code here instead of the conditionals with
----------------
We don't want this part of the comment in the final patch.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:990
+    //  We have to put this code here instead of the conditionals with
+    //    cannotDivide() in order to work with sext expressions.
+    assert(Numerator->getStart()->getType() == StartQ->getType() &&
----------------
Instead of talking about why the code is here instead of somewhere else, it's probably better to talk about what the code is doing.  What expectations are being verified?


Repository:
  rL LLVM

https://reviews.llvm.org/D40369