[PATCH] D49806: [FPEnv] Widen illegal width StrictFP vector operations as needed

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally marked 5 inline comments as done.
cameron.mcinally added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2607
+    if (Oper.getValueType().isVector())
+      Oper = GetWidenedVector(N->getOperand(i));
+
----------------
craig.topper wrote:
> Add an assert here that the operand VT matches the destination VT when we call GetWidenedVector?
That assert won't be valid for converts (yet to be added) and possibly other strict instructions.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2679
+
+  // Check to see if we have a single operation with the widen type.
+  if (ConcatEnd == 1) {
----------------
craig.topper wrote:
> Is the code from here an exact copy/paste from the other function? Can we add a shared helper function?
It is the same as above (side note: I just noticed that the yellow bar in Phabricator shows where the code was copied from).

This looks like a reasonable thing to do. I'll work on that now...


Repository:
  rL LLVM

https://reviews.llvm.org/D49806