[PATCH] D49644: [COFF] Hoist constant pool handling from X86AsmPrinter into AsmPrinter

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 10:46:31 PDT 2018


efriedma accepted this revision.
efriedma added a comment.

Looks fine.



================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:240
+  // The AsmPrinter::GetCPISymbol superclass method tries
+  // to use CPID as indexes in MachineConstantPoil, which
+  // isn't in sync with indexes used here.
----------------
*MachineConstantPool.


https://reviews.llvm.org/D49644





More information about the llvm-commits mailing list