[PATCH] D49786: Enable some pointer authentication instructions for aarch64 v8a targets

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 08:38:28 PDT 2018


thopre added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.td:544
 
-  let isReturn = 1 in {
+  let isReturn = 1, isTerminator = 1, isBarrier = 1 in {
     def RETAA   : AuthReturn<0b010, 0, "retaa">;
----------------
This change does not appear related to the change described. It should IMHO either be split in a separate patch or if that is deemed too cumbersome it should at least be mentioned in the patch description (and thus commit message).


Repository:
  rL LLVM

https://reviews.llvm.org/D49786





More information about the llvm-commits mailing list