[PATCH] D49777: [LTO] Don't internalize declarations

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 06:53:36 PDT 2018


tejohnson added a comment.

Code change looks fine, but please reduce the test case. - there's a lot of stuff there that likely isn't needed to reproduce.



================
Comment at: llvm/test/LTO/X86/pr38046.ll:12
+; RUN:   -r=t.o,_ZN1A3getEv,pl
+; RUN: llvm-dis m.0.2.internalize.bc > /dev/null
+
----------------
I guess llvm-dis will fail without the patch. Still, would be good to add a check for the declaration that was being internalized


https://reviews.llvm.org/D49777





More information about the llvm-commits mailing list