[PATCH] D44030: [WebAssembly] Tidy up handling of global symbol relocations

[Dan Gohman via Phabricator via llvm-commits]

sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.

First, I apologize, I'm not sure how I lost track of this patch and didn't see the pings.

The patch looks good to me. Adding @GLOBAL rather than inferring it from the fact that a symbol appears in a get_global/set_global seems reasonable.



================
Comment at: include/llvm/MC/MCExpr.h:282
     VK_WebAssembly_FUNCTION, // Function table index, rather than virtual addr
+    VK_WebAssembly_GLOBAL, // Global object index
     VK_WebAssembly_TYPEINDEX,// Type table index
----------------
Please vertically align the comment here.


Repository:
  rL LLVM

https://reviews.llvm.org/D44030