[PATCH] D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7222
+  if (OpInfo.isMatchingInputConstraint())
+    return;
+
----------------
I don't follow this... don't we need to allocate virtual registers anyway?  And how is this relevant to this patch?


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7476
+            : ConstraintOperands[i];
     if (OpInfo.ConstraintType == TargetLowering::C_Register)
+      GetRegistersForValue(DAG, TLI, getCurSDLoc(), OpInfo, RefOpInfo);
----------------
Why is this "OpInfo.ConstraintType == TargetLowering::C_Register" here, but "RefOpInfo.ConstraintType == TargetLowering::C_RegisterClass" later?


Repository:
  rL LLVM

https://reviews.llvm.org/D48434