[PATCH] D49764: Simplify ObjFile::createDefined().
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 24 16:48:40 PDT 2018
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/COFF/InputFiles.cpp:259
} else {
- // createDefined() returns None if a symbol belongs to a section that
- // was pending at the point when the symbol was read. This can happen in
- // two cases:
- // 1) section definition symbol for a comdat leader;
- // 2) symbol belongs to a comdat section associated with a section whose
- // section definition symbol appears later in the symbol table.
- // In both of these cases, we can expect the section to be resolved by
- // the time we finish visiting the remaining symbols in the symbol
- // table. So we postpone the handling of this symbol until that time.
+ // createDefined() returns None for an associtave comdat section symbol.
+ // Such symbol is processed in the second pass (in the following for-loop),
----------------
associative
Or a section definition symbol for a comdat leader, still.
================
Comment at: lld/COFF/InputFiles.cpp:260
+ // createDefined() returns None for an associtave comdat section symbol.
+ // Such symbol is processed in the second pass (in the following for-loop),
+ // so we just record their indices for now.
----------------
These symbols are processed
================
Comment at: lld/COFF/InputFiles.cpp:264
+ // We need to do this in two passes to handle forward references. An
+ // associative symbol can refer to a comdat symbols that appears later in
+ // the symbol table.
----------------
a comdat symbol
https://reviews.llvm.org/D49764
More information about the llvm-commits
mailing list