[PATCH] D49464: [COFF, ARM64] Decide when to mark struct returns as SRet

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Looks fine except for a couple minor nits.



================
Comment at: include/clang/CodeGen/CGFunctionInfo.h:99
   bool SignExt : 1;         // isExtend()
+  bool SuppressSRet : 1;
 
----------------
Maybe enforce `isIndirect()`, like we do for other similar flags?


================
Comment at: test/CodeGen/arm64-microsoft-arguments.cpp:1
+// RUN: %clang_cc1 -triple aarch64-windows -ffreestanding -emit-llvm -O1 \
+// RUN: -x c++ -o - %s | FileCheck %s
----------------
Please use -O0 for CodeGen tests, where possible.


https://reviews.llvm.org/D49464